apoorvmittal10 opened a new pull request, #22912: URL: https://github.com/apache/kafka/pull/22912
AbstractResponse.shouldClientThrottle() defaults to false, so responses that carry a throttle_time_ms field but don't override it never trigger client-side throttling — the client ignores the broker's throttle time on quota violations. This adds the missing override to every response that declares a throttle_time_ms field, including the group heartbeat responses called out in the JIRA (ConsumerGroupHeartbeatResponse, ShareGroupHeartbeatResponse, StreamsGroupHeartbeatResponse). OffsetsForLeaderEpochResponse returns version >= 2 (the version that added the throttle field). A regression test in RequestResponseTest asserts that every API whose response schema has a throttle_time_ms field returns true from shouldClientThrottle() at its latest version, so new APIs can't reintroduce the bug. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
