zheguang commented on code in PR #22910:
URL: https://github.com/apache/kafka/pull/22910#discussion_r3635689424
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##########
@@ -167,7 +167,11 @@ public void run() {
}
} catch (final RuntimeException anyOtherException) {
handleRuntimeException(anyOtherException);
+ } catch (final Error fatalError) {
+ log.error("A fatal error occurred within the state updater
thread", fatalError);
+ throw fatalError;
} finally {
+ isRunning.set(false);
Review Comment:
Minor redundancy: same `isRunning.set(false)` in the case for
RuntimeException (in `handleRuntimeException()`) as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
