Ritikj55 commented on PR #22684: URL: https://github.com/apache/kafka/pull/22684#issuecomment-5058471883
> @Ritikj55 Thanks for the PR, there are some changes required > > Some metrics are missing (their -max counterparts, 5-6 entries). > > `time-between-network-thread-poll` should have `-max`/`-avg` suffix. > > `application-event-queue-processing-time-avg` definition seems incorrect. Verify from code > > mbean pattern is not consistent. Please conform to the common style. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
