Jess668 commented on code in PR #22853:
URL: https://github.com/apache/kafka/pull/22853#discussion_r3638652719
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredTimestampedWindowStoreWithHeaders.java:
##########
@@ -152,17 +154,15 @@ public <R> QueryResult<R> query(
result =
runTimestampedWindowKeyWithHeadersQuery((TimestampedWindowKeyWithHeadersQuery<K,
V>) query, positionBound, config);
} else if (query instanceof WindowRangeQuery) {
result = runWindowRangeQuery((WindowRangeQuery<K,
ValueTimestampHeaders<V>>) query, positionBound, config);
+ } else if (query instanceof TimestampedWindowRangeWithHeadersQuery) {
+ result =
runTimestampedWindowRangeWithHeadersQuery((TimestampedWindowRangeWithHeadersQuery<K,
V>) query, positionBound, config);
} else {
result = wrapped().query(query, positionBound, config);
}
if (config.isCollectExecutionInfo()) {
- final String conversionType = isUnderlyingStoreTimestamped()
- ? "with conversion to ValueAndTimestamp"
- : "with extraction of plain values";
result.addExecutionInfo(
- "Handled in " + getClass() + " " + conversionType + " in "
- + (time.nanoseconds() - start) + "ns");
+ "Handled in " + getClass() + " in " + (time.nanoseconds() -
start) + "ns");
Review Comment:
was intentional, but you're right that it left the two `*WithHeaders` stores
reporting differently. will fix to emit an identical format
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
