Parkerhiphop commented on code in PR #22932:
URL: https://github.com/apache/kafka/pull/22932#discussion_r3656061903
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##########
@@ -141,8 +138,6 @@ public Optional<String> serverConfigName(String configName)
{
public static final boolean DEFAULT_PREALLOCATE = false;
public static final boolean DEFAULT_REMOTE_STORAGE_ENABLE = false;
- public static final boolean DEFAULT_REMOTE_LOG_COPY_DISABLE_CONFIG = false;
Review Comment:
Good point. Do you think we should also use the corresponding default
constant to another one?
```java
.define(TopicConfig.REMOTE_LOG_DELETE_ON_DISABLE_CONFIG, BOOLEAN,
DEFAULT_REMOTE_LOG_DELETE_ON_DISABLE_CONFIG, MEDIUM,
TopicConfig.REMOTE_LOG_DELETE_ON_DISABLE_DOC)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
