nicktelford opened a new pull request, #22959: URL: https://github.com/apache/kafka/pull/22959
Existing tests verifying state-wipe behaviour on dirty EOS close need to be scoped to the non-transactional case, since transactional state stores never let uncommitted writes reach the base store and so should not be wiped on error. Most of this was already covered by earlier KIP-892 work — `StateManagerUtilTest`, `StandbyTaskTest`, `ProcessorStateManagerTest`, and `StandbyTaskEOSIntegrationTest` already exercise both the transactional and non-transactional paths correctly. Two gaps remained: - `StreamTaskTest` had a non-transactional active-task wipe test but no transactional counterpart (unlike its `StandbyTaskTest` sibling), so this adds `shouldNotWipeStateDirectoryWhenCloseDirtyAndEosEnabledWithTransactionalStateStores` mirroring the existing pattern. - `EOSUncleanShutdownIntegrationTest` had no transactional coverage at all, and mutated a shared static `Properties` field in place (a footgun once a second test method exists). This refactors both tests to build their own `Properties` copy, makes the existing test explicitly non-transactional, and adds `shouldNotWipeStateStoreOnUncleanShutdownWhenTransactional` asserting the state directory survives an unclean shutdown when transactional stores are enabled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
