ChoMinGi opened a new pull request, #22965:
URL: https://github.com/apache/kafka/pull/22965
Backports the following fixes to the `4.2` branch:
- #22073
- #22836
#22073 applied cleanly.
#22836 conflicted in two places:
- `ShareHeartbeatRequestManagerTest`: import section only. The 4.2 branch
already uses `anyBoolean()`, so the existing `anyBoolean` import was
retained.
- `AbstractHeartbeatRequestManager#maximumTimeToWait`: the trunk diff context
includes the `UNSUBSCRIBED` early return introduced by #21239, which is not
on 4.2. Only the KAFKA-20253 guard was applied. `shouldSkipHeartbeat()`
already covers `UNSUBSCRIBED` on 4.2, so an unsubscribed member returns
`heartbeatIntervalMs()` here instead of trunk's `Long.MAX_VALUE` — bounded
wake-ups, no spin.
Testing:
`./gradlew :clients:test --tests
'org.apache.kafka.clients.consumer.internals.AbstractCoordinatorTest' --tests
'org.apache.kafka.clients.consumer.internals.ConsumerHeartbeatRequestManagerTest'
--tests
'org.apache.kafka.clients.consumer.internals.CoordinatorRequestManagerTest'
--tests
'org.apache.kafka.clients.consumer.internals.ShareHeartbeatRequestManagerTest'`
All four test classes pass locally on this branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
