arnabnandy7 commented on code in PR #22864:
URL: https://github.com/apache/kafka/pull/22864#discussion_r3667172610
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##########
@@ -718,15 +710,19 @@ private void maybeCompleteRestoration(final StreamTask
task,
changelogReader.unregister(changelogPartitions);
addToRestoredTasks(task);
log.info("Stateful active task " + task.id() + " completed
restoration");
- transitToUpdateStandbysIfOnlyStandbysLeft();
+ maybeTransitionChangelogReader();
} catch (final StreamsException streamsException) {
handleStreamsExceptionWithTask(streamsException,
task.id());
}
}
}
- private void transitToUpdateStandbysIfOnlyStandbysLeft() {
- if (onlyStandbyTasksUpdating()) {
+ private void maybeTransitionChangelogReader() {
+ if (updatingTasks.isEmpty()) {
+ if (!changelogReader.isRestoringActive()) {
Review Comment:
@Nikita-Shupletsov thanks for reviewing, I've remediated it. Please check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
