aliehsaeedii commented on code in PR #22961: URL: https://github.com/apache/kafka/pull/22961#discussion_r3667561651
########## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBListValueHeadersBytesStoreSupplier.java: ########## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.streams.state.internals; + +import org.apache.kafka.common.utils.Bytes; +import org.apache.kafka.streams.state.KeyValueBytesStoreSupplier; +import org.apache.kafka.streams.state.KeyValueStore; + +/** + * Supplies the persistent, dual-column-family {@link RocksDBListValueStoreWithHeaders} used as the + * bytes store for the outer-join {@link ListValueStore} in HEADERS mode. + */ +public class RocksDBListValueHeadersBytesStoreSupplier implements KeyValueBytesStoreSupplier { Review Comment: This store deliberately isn't `HeadersBytesStore` — being one would make `WrappedStateStore#isHeadersAware` true and `converterForStore` would pick `rawValueToHeadersValue()`, corrupting the list blob. It's also read by the materializers, so marking it would let `Materialized.as(...)` route this supplier to the wrong builder. But I agree with your point on `ListValueStoreBuilder` — the boolean should go. I'll give the list supplier its own internal marker and infer `headersFormat` from that instead, which also lets `OuterStreamJoinStoreFactory` derive the value serde from the same check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
