dejan2609 commented on PR #21373: URL: https://github.com/apache/kafka/pull/21373#issuecomment-5110258972
Hi @Shivamrut ! Solution is actually working as expected (and I just rebased it onto trunk without a single conflict :slightly_smiling_face:) but the real question is: should we try to merge in now or just before (during ?) Gradle major version upgrade from 9 to 10 ? _Prologue (why we need to do this at some point):_ https://docs.gradle.org/9.4.1/userguide/upgrading_version_8.html#groovy_space_assignment_syntax > These generated methods are now deprecated and will be removed in Gradle 10, and both propertyName value and propertyName(value) will stop working unless the explicit method propertyName is defined. **_Use explicit assignment propertyName = value instead._** ### Test procedure: 1. Current trunk state problem report after `./gradlew clean rTG` execution - `propName/value` syntax related warnings are shown :warning:: <img width="1342" height="724" alt="image" src="https://github.com/user-attachments/assets/6066cd93-dc69-4c8c-9e76-c01bb7bfa4c5"; /> 2. This PR state problem report after `./gradlew clean rTG` execution - `propName/value` syntax related warnings are gone :white_check_mark:: <img width="908" height="518" alt="image" src="https://github.com/user-attachments/assets/d5c83c93-c833-4b9f-a492-0454beffbf41"; /> What is your take on this @chia7712 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
