muralibasani commented on code in PR #22901:
URL: https://github.com/apache/kafka/pull/22901#discussion_r3669884150
##########
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/HeadersStoreUpgradeIntegrationTest.java:
##########
@@ -468,36 +528,16 @@ private <K, V> void
processKeyValueWithTimestampAndHeadersAndVerify(final K key,
final
Headers expectedHeaders)
throws Exception {
- IntegrationTestUtils.produceKeyValuesSynchronouslyWithTimestamp(
- inputStream,
- singletonList(KeyValue.pair(key, value)),
- TestUtils.producerConfig(CLUSTER.bootstrapServers(),
- StringSerializer.class,
- StringSerializer.class),
- headers,
- timestamp,
- false);
-
- TestUtils.waitForCondition(
- () -> {
- try {
- final ReadOnlyKeyValueStore<K, ValueTimestampHeaders<V>>
store = IntegrationTestUtils
- .getStore(STORE_NAME, kafkaStreams,
QueryableStoreTypes.timestampedKeyValueStoreWithHeaders());
-
- if (store == null)
- return false;
+ produce(key, value, timestamp, headers);
- final ValueTimestampHeaders<V> result = store.get(key);
- return result != null
- && result.value().equals(value)
- && result.timestamp() == timestamp
- && result.headers().equals(expectedHeaders);
- } catch (final Exception swallow) {
- LOG.error("Failed to retrieve expected result", swallow);
- return false;
- }
+ awaitStore(STORE_NAME, QueryableStoreTypes.<K,
V>timestampedKeyValueStoreWithHeaders(),
Review Comment:
Done, the 5-arg overload now delegates to the 6-arg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
