chia7712 commented on code in PR #22584:
URL: https://github.com/apache/kafka/pull/22584#discussion_r3670636158
##########
server/src/main/java/org/apache/kafka/server/ForwardingManagerImpl.java:
##########
@@ -102,10 +99,10 @@ public void onComplete(ClientResponse clientResponse) {
// return `UNKNOWN_SERVER_ERROR` so that the user
knows that there is a problem
// on the broker.
LOG.debug("Forwarded request {} failed with an
error in the envelope response {}",
- requestToString.get(), envelopeError);
+ originalRequest, envelopeError);
response =
requestBody.getErrorResponse(Errors.UNKNOWN_SERVER_ERROR.exception());
} else {
- response =
parseResponse(envelopeResponse.responseData(), requestBody,
requestContext.header);
+ response =
parseResponse(envelopeResponse.responseData(), requestBody,
originalRequest.context().header);
Review Comment:
never mind. It seems `.context.header` is used frequently in our codebase.
That is a kind of taste I guess :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
