kevin-wu24 commented on code in PR #22191: URL: https://github.com/apache/kafka/pull/22191#discussion_r3683991503
########## clients/src/main/resources/common/message/UnregisterControllerRequest.json: ########## @@ -0,0 +1,27 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +{ + "apiKey": 94, + "type": "request", + "listeners": ["broker", "controller"], + "name": "UnregisterControllerRequest", + "validVersions": "0", + "flexibleVersions": "0+", + "fields": [ + { "name": "ControllerId", "type": "int32", "versions": "0+", Review Comment: I'm not super clear on the purpose of `entityType`, but I did not add it because `RegisterControllerRecord` does not use it either. This is what claude said: ``` entityType is nearly inert in codegen. The only consumers are FieldSpec.java:100, which calls verifyTypeMatches to assert the declared type matches the entity's base type (brokerId → int32), and Target.java:50, which just copies it through. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
