aliehsaeedii opened a new pull request, #23007:
URL: https://github.com/apache/kafka/pull/23007

   [KAFKA-20413](https://issues.apache.org/jira/browse/KAFKA-20413) made the 
`suppress()` buffer headers-aware when `dsl.store.format=HEADERS` is configured 
(`InMemoryTimeOrderedKeyValueChangeBuffer`), but four documentation locations 
still claim that `suppress()` loses headers:
   
   - `dsl-api.md` "Note on headers-aware state stores" on `suppress()`
   - `dsl-api.md` KIP-1285 current-behavior bullets
   - `config-streams.md` `dsl.store.format` "Current limitations"
   - `upgrade-guide.md` KIP-1285 "Current limitations"
   
   Each of those mentioned `suppress()` together with left/outer stream-stream 
joins, whose not-yet-matched buffer is still not headers-aware, so the shared 
statements are split in two:
   
   - `suppress()` now describes the actual behavior: each buffered value is 
stored together with the headers of the record it came from, and the record 
emitted when a row is evicted carries the headers of the value being emitted. 
Under `dsl.store.format=DEFAULT` the buffer still keeps plain values plus a 
single record context per row, so a row updated by a later record before 
eviction preserves only that later record's headers — that limitation is stated 
where it is relevant.
   - The left/outer stream-stream join buffer keeps the pre-existing "records 
that pass through this buffer lose their headers" statement.
   
   One adjacent correction: the `upgrade-guide.md` "Changelog, migration, and 
performance" paragraph said KIP-1285 leaves the changelog untouched. Under 
`HEADERS`, the suppress changelog records keep the existing V3 value format but 
carry the buffered old and prior values' headers in additional `vh.old` / 
`vh.prior` record headers, which older versions ignore on restore. Added a 
sentence covering that, including the downgrade implication.
   
   Docs only — no code changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to