lh0156 commented on PR #22935: URL: https://github.com/apache/kafka/pull/22935#issuecomment-5159309028
Follow-up on the review threads: - The test fixtures now consistently use `oldConfig` and document the current session/heartbeat ranges. - The evaluated-old-session-timeout test covers a different path from the unchanged-value regression. - The three-argument `GroupConfig.validate` overload is still used by the existing `GroupConfigTest` cases and is also the shared validation path used by the alter overload. - The alter path evaluates the old configuration, overlays only changed values, and delegates to the existing validation path, so validation logic is not duplicated. Verification after the latest commit: - `./gradlew :group-coordinator:test --tests org.apache.kafka.coordinator.group.GroupConfigTest --no-build-cache` - `./gradlew :core:test --tests kafka.server.ControllerConfigurationValidatorTest --no-build-cache` Both passed. @squah-confluent, could you please re-review the current tree? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
