[
https://issues.apache.org/jira/browse/KAFKA-20835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18101093#comment-18101093
]
Yunseop Eom commented on KAFKA-20835:
-------------------------------------
Follow-up on PR #22935: https://github.com/apache/kafka/pull/22935
I addressed the review feedback by keeping the existing validation path,
evaluating effective session and heartbeat values, validating only values
changed by the current alter request, retaining coverage for stale out-of-range
overrides, and removing redundant test ambiguity.
The targeted GroupConfigTest and ControllerConfigurationValidatorTest suites,
plus group-coordinator and core formatting checks, pass locally. The PR is open
and ready for maintainer re-review.
> Group-level alter-config RPC fails, if single group config is invalid
> ---------------------------------------------------------------------
>
> Key: KAFKA-20835
> URL: https://issues.apache.org/jira/browse/KAFKA-20835
> Project: Kafka
> Issue Type: Bug
> Components: group-coordinator
> Reporter: Matthias J. Sax
> Assignee: Chia-Ping Tsai
> Priority: Minor
>
> ControllerConfigurationValidator gets the full post-alter override map, not
> just the altered keys. So if a broker bound is narrowed after an override was
> set, GroupConfig.validate() rejects the stale value on every later alter –
> even one that doesn't touch it.
> Repro: set consumer.session.timeout.ms=90000 on a group, restart controller
> with group.consumer.max.session.timeout.ms=60000, then try to alter
> consumer.heartbeat.interval.ms on the same group -> INVALID_CONFIG on the
> session timeout.
> Impact: the group is stuck until the stale key is fixed or deleted.
> Validation is all-or-nothing per resource, and throws on the first violation,
> so multiple stale keys must all be repaired in one request, discovered one
> error at a time.
> It seems LogConfig may have a similar issue.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
