lh0156 opened a new pull request, #23031:
URL: https://github.com/apache/kafka/pull/23031

   ## Summary
   
   - Remove the deprecated Yammer-based group coordinator metrics scheduled for 
removal in Kafka 5.0.
   - Simplify `GroupCoordinatorMetrics` to use Kafka Metrics only, including 
its constructor, registration, and cleanup paths.
   - Update the broker, benchmark, coordinator tests, test utilities, and 
monitoring documentation for the Kafka Metrics replacements.
   - Jira: https://issues.apache.org/jira/browse/KAFKA-20679
   
   ## TDD verification
   
   - RED: on the baseline, a test asserting that deprecated Yammer metrics are 
not registered failed because the old gauges were present (`expected: <true> 
but was: <false>`).
   - GREEN: after the production removal, the coordinator metrics tests pass 
and the deprecated Yammer APIs are no longer referenced in the affected paths.
   
   ## Testing
   
   - `./gradlew :group-coordinator:test --tests 
org.apache.kafka.coordinator.group.metrics.GroupCoordinatorMetricsTest --tests 
org.apache.kafka.coordinator.group.metrics.GroupCoordinatorMetricsShardTest 
--no-build-cache --console=plain`
   - `./gradlew :group-coordinator:test --no-build-cache --console=plain`
   - `./gradlew :core:compileScala :jmh-benchmarks:compileJava --no-build-cache 
--console=plain --quiet`
   - Checkstyle and SpotBugs completed successfully as part of the coordinator 
test task.
   - `git diff --check`
   
   The deprecated metrics were explicitly marked for Kafka 5.0 removal in 
KIP-1301, and the replacement metrics remain covered by the existing Kafka 
Metrics assertions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to