[
https://issues.apache.org/jira/browse/KAFKA-20866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18101125#comment-18101125
]
Yunseop Eom commented on KAFKA-20866:
-------------------------------------
Opened https://github.com/apache/kafka/pull/23032 for KAFKA-20866.
Summary:
- Removed incremental-strategy-only outcome and extensionBytesNeeded state from
regular RecordAppendResult instances.
- Kept extension capacity in a private result subtype and updated
ChunkedRecordAccumulator to use the package-private accessor.
- Added regression coverage for the buffer-extension result contract.
TDD and verification:
- RED: the new test failed to compile because extensionBytesNeeded() did not
exist.
- GREEN: targeted RecordAccumulatorTest and ChunkedRecordAccumulatorTest passed.
- Full :clients:test passed, including checkstyle and SpotBugs.
- :clients:spotlessJavaCheck passed.
The PR is ready for maintainer review.
> Remove incremental-only fields from RecordAppendResult
> ------------------------------------------------------
>
> Key: KAFKA-20866
> URL: https://issues.apache.org/jira/browse/KAFKA-20866
> Project: Kafka
> Issue Type: Sub-task
> Reporter: Lianet Magrans
> Assignee: Lianet Magrans
> Priority: Minor
>
> For the incremental strategy we added two fields to
> RecordAccumulator.RecordAppendResult (outcome and extensionBytesNeeded)
> Neither is used by the default full strategy but RecordAppendResult is
> created per successful append, so both strategies now carry two fields that
> only one of them reads.
> No impact on latency, just per-append state (bytes for obj in mem) it does
> not need, and a small refactor removes itÂ
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
