[
https://issues.apache.org/jira/browse/KAFKA-20881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18101202#comment-18101202
]
Yunseop Eom commented on KAFKA-20881:
-------------------------------------
Opened PR #23061: https://github.com/apache/kafka/pull/23061
The Connect system-test classpath helper now skips generated -javadoc.jar files
when selecting the runtime plugin artifact. This prevents the javadoc archive
from being loaded instead of connect-file's runtime JAR after KAFKA-20032.
TDD verification:
- RED: the focused unit test selected connect-file-4.0.0-SNAPSHOT-javadoc.jar
before the change.
- GREEN: the focused regression test passes after excluding -javadoc.jar.
- Full tests/unit suite: 7 passed.
- Python compileall and git diff --check passed.
- No public API, protocol, or configuration changes.
> System tests fail to load connect-file plugin due to javadoc.jar conflict
> -------------------------------------------------------------------------
>
> Key: KAFKA-20881
> URL: https://issues.apache.org/jira/browse/KAFKA-20881
> Project: Kafka
> Issue Type: Improvement
> Reporter: Chia-Ping Tsai
> Assignee: majialong
> Priority: Major
>
> KAFKA-20032 makes the javadoc jar always be generated, so the following code
> used to search the connect-file jar does not work now.
> {code:py}
> def append_module_to_classpath(self, module):
> cwd = os.getcwd()
> relative_path = "/connect/" + module + "/build/libs/"
> local_dir = cwd + relative_path
> lib_dir = self.path.home() + relative_path
> for pwd, dirs, files in os.walk(local_dir):
> for file in files:
> if file.endswith(".jar"):
> # Use the expected directory on the node instead of the
> path in the driver node
> file_path = lib_dir + file
> self.logger.info("Appending %s to Connect worker's
> CLASSPATH" % file_path)
> return "export CLASSPATH=${CLASSPATH}:%s; " % file_path
> self.logger.info("Jar not found within %s" % local_dir)
> return ""
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
