[
https://issues.apache.org/jira/browse/KAFKA-20855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18101266#comment-18101266
]
Yunseop Eom edited comment on KAFKA-20855 at 8/3/26 10:28 AM:
--------------------------------------------------------------
PR: https://github.com/apache/kafka/pull/23066
Extracted the KIP-909 bootstrap DNS resolution lifecycle from NetworkClient
into a package-private BootstrapServerResolver. The behavior and public
interfaces remain unchanged. Added TDD coverage for successful resolution,
retry after empty or exceptional results, timeout failure,
interruption/cancellation, and the disabled bootstrap configuration.
Follow-up commits:
- 962c3c232a: make the cancellation test explicitly tolerate an interrupted
resolver thread and preserve its interrupt status.
- 6eb8273d1d: verify that the DISABLED configuration neither starts DNS
resolution nor reports metadata changes.
Verification:
- :clients:test --tests org.apache.kafka.clients.BootstrapServerResolverTest
--rerun-tasks: 6 tests passed.
- Full :clients:test: BUILD SUCCESSFUL after 5 minutes.
- Spotless, Checkstyle, SpotBugs, and git diff --check passed.
No public API, protocol, configuration semantics, or KIP changes. PR remains
open and awaiting maintainer review; not merged.
was (Author: JIRAUSER313210):
PR: https://github.com/apache/kafka/pull/23066
Extracted the KIP-909 bootstrap DNS resolution lifecycle from NetworkClient
into a package-private BootstrapServerResolver. The behavior and public
interfaces remain unchanged. Added TDD coverage for successful resolution,
retry after empty or exceptional results, timeout failure, and cancellation
after an interrupted poll. The follow-up commit 962c3c232a makes the
cancellation test explicitly tolerate an interrupted resolver thread and
preserve its interrupt status.
Verification: clients test suite focused on BootstrapServerResolverTest and
NetworkClientTest, Spotless, Checkstyle, and SpotBugs all pass.
> Refactor NetworkClient
> ----------------------
>
> Key: KAFKA-20855
> URL: https://issues.apache.org/jira/browse/KAFKA-20855
> Project: Kafka
> Issue Type: Improvement
> Reporter: Chia-Ping Tsai
> Assignee: Cheng Yi Chang
> Priority: Major
>
> KIP-909 adds more logic to NetworkClient... We should try to simplify it by
> extracting some logic from NetworkClient
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
