gabriellefu commented on code in PR #23006:
URL: https://github.com/apache/kafka/pull/23006#discussion_r3706309086
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/topics/EndpointToPartitionsManager.java:
##########
@@ -74,10 +74,14 @@ public static
StreamsGroupHeartbeatResponseData.EndpointToPartitions endpointToP
entry -> entry.getValue().keySet()
));
Map<String, Set<Integer>> standbyTasks =
streamsGroupMember.assignedTasks().standbyTasks();
+ Map<String, Set<Integer>> warmupTasks =
streamsGroupMember.assignedTasks().warmupTasks();
endpointToPartitions.setUserEndpoint(responseEndpoint);
Map<String, ConfiguredSubtopology> configuredSubtopologies =
streamsGroup.configuredTopology().flatMap(ConfiguredTopology::subtopologies).get();
List<StreamsGroupHeartbeatResponseData.TopicPartition>
activeTopicPartitions = topicPartitions(activeTasks, configuredSubtopologies,
metadataImage);
List<StreamsGroupHeartbeatResponseData.TopicPartition>
standbyTopicPartitions = topicPartitions(standbyTasks, configuredSubtopologies,
metadataImage);
+ List<StreamsGroupHeartbeatResponseData.TopicPartition>
warmupTopicPartitions = topicPartitions(warmupTasks, configuredSubtopologies,
metadataImage);
+ // Warm-up tasks are executed as standby tasks on the client, so they
are reported as standby partitions, as in the classic protocol.
+ standbyTopicPartitions.addAll(warmupTopicPartitions);
Review Comment:
thanks for the education, I will update the pr after
https://github.com/apache/kafka/pull/23050 get merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
