chia7712 commented on code in PR #23076:
URL: https://github.com/apache/kafka/pull/23076#discussion_r3722698771
##########
tests/kafkatest/services/connect.py:
##########
@@ -314,13 +315,12 @@ def append_module_to_classpath(self, module):
relative_path = "/connect/" + module + "/build/libs/"
local_dir = cwd + relative_path
lib_dir = self.path.home() + relative_path
- for pwd, dirs, files in os.walk(local_dir):
- for file in files:
- if file.endswith(".jar"):
- # Use the expected directory on the node instead of the
path in the driver node
- file_path = lib_dir + file
- self.logger.info("Appending %s to Connect worker's
CLASSPATH" % file_path)
- return "export CLASSPATH=${CLASSPATH}:%s; " % file_path
+ jar_name = "connect-%s-%s.jar" % (module, DEV_VERSION)
Review Comment:
As long as we only add dev version files, this approach is safe and simpler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
