sumanpal97 opened a new pull request, #23126:
URL: https://github.com/apache/kafka/pull/23126

   ## Summary
   - Make the `openIterators` comparator total by tie-breaking on a 
per-iterator sequence id, so iterators opened in the same millisecond are 
tracked uniquely in metered store wrappers.
   - Add regression tests covering same-ms iterators (close older first, close 
younger first) and different iterator types sharing one `openIterators` set.
   
   Fixes [KAFKA-20902](https://issues.apache.org/jira/browse/KAFKA-20902).
   
   ## Test plan
   - [x] `./gradlew :streams:build` (compile, checkstyle, all streams unit 
tests)
   - [x] New regression tests fail without the fix and pass with it:
     - 
`MeteredKeyValueStoreTest.shouldTrackOldestOpenIteratorWhenTwoOpenedInSameMillisecond`
     - 
`MeteredKeyValueStoreTest.shouldTrackOldestOpenIteratorWhenYoungerIteratorInSameMillisecondIsClosedFirst`
     - 
`MeteredWindowStoreTest.shouldTrackOldestOpenIteratorWhenDifferentIteratorTypesOpenedInSameMillisecond`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to