bbejeck commented on PR #23086: URL: https://github.com/apache/kafka/pull/23086#issuecomment-5258537469
@alanlau28 with merging https://github.com/apache/kafka/pull/23037 we should rebase this PR as I think some of the refactoring may have reached this PR. Overall this is looking good to me but I think we need to harden this some to guard against a constant probing due crash-looping. - we could bound the `beginningOffsets` call using the overaload that accpets a `Duration` parameter - Bound the overall probe process. Each probe is bounded but the number of attempts are not. A bad task i.e. `TaskCorrupted → wipe → re-register with a null offset` will trigger a full probe every iteration without an indication that it already gave up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
