UladzislauBlok commented on code in PR #23134:
URL: https://github.com/apache/kafka/pull/23134#discussion_r3769241436
##########
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/OptimizedKTableIntegrationTest.java:
##########
@@ -222,4 +224,23 @@ private Properties streamsConfiguration(final String
safeTestName) {
config.put(ConsumerConfig.SESSION_TIMEOUT_MS_CONFIG, 1000);
return config;
}
+
+ private static class FixedPartitionPartitioner implements
StreamPartitioner<Integer, Object> {
Review Comment:
@mjsax
Thanks for comments
- Moved `FixedPartitionPartitioner` to `test-fixtures` (let me know if you
disagree with package)
- Fixed tests, and re-run tests + int tests. All green localy
##########
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/OptimizedKTableIntegrationTest.java:
##########
@@ -222,4 +224,23 @@ private Properties streamsConfiguration(final String
safeTestName) {
config.put(ConsumerConfig.SESSION_TIMEOUT_MS_CONFIG, 1000);
return config;
}
+
+ private static class FixedPartitionPartitioner implements
StreamPartitioner<Integer, Object> {
Review Comment:
@mjsax
Thanks for comments
- Moved `FixedPartitionPartitioner` to `test-fixtures` (let me know if you
disagree with package)
- Fixed tests, and re-run tests + int tests. All green locally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
