chia7712 commented on code in PR #23083:
URL: https://github.com/apache/kafka/pull/23083#discussion_r3773991385
##########
clients/src/main/java/org/apache/kafka/clients/admin/StreamsGroupDescription.java:
##########
@@ -247,7 +247,9 @@ public String toString() {
", members=" +
members.stream().map(StreamsGroupMemberDescription::toString).collect(Collectors.joining(","))
+
", groupState=" + groupState +
", coordinator=" + coordinator +
- ", authorizedOperations=" +
authorizedOperations.stream().map(AclOperation::toString).collect(Collectors.joining(","))
+
+ ", authorizedOperations=" + (authorizedOperations == null ?
Review Comment:
It seems that other description classes simply use `",
authorizedOperations=" + authorizedOperations`, which can resolve this NPE as
well, and the output is readable.
The current approach is fine. I'm just reviewing code and a bit nitpicky
today :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
