squah-confluent commented on code in PR #23155:
URL: https://github.com/apache/kafka/pull/23155#discussion_r3778582888
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/RangeAssignorTest.java:
##########
@@ -70,8 +71,31 @@ public class RangeAssignorTest {
"HETEROGENEOUS, false",
"HETEROGENEOUS, true"
})
- public void testReassignmentStickiness(SubscriptionType subscriptionType,
boolean rackAware) {
- CommonAssignorTests.testReassignmentStickiness(assignor,
subscriptionType, rackAware);
+ public void testIterationOrderStickiness(SubscriptionType
subscriptionType, boolean rackAware) {
+ CommonAssignorTests.testIterationOrderStickiness(assignor,
subscriptionType, rackAware);
+ }
+
+ @ParameterizedTest
+ @CsvSource({
+ "HOMOGENEOUS, false",
+ "HOMOGENEOUS, true",
+ "HETEROGENEOUS, false",
+ "HETEROGENEOUS, true"
+ })
+ public void testStaticMemberReplacementStickiness(SubscriptionType
subscriptionType, boolean rackAware) {
+ CommonAssignorTests.testStaticMemberReplacementStickiness(assignor,
subscriptionType, rackAware);
+ }
+
+ @Disabled("RangeAssignor is not currently sticky when members are
replaced.")
+ @ParameterizedTest
+ @CsvSource({
+ "HOMOGENEOUS, false",
+ "HOMOGENEOUS, true",
+ "HETEROGENEOUS, false",
+ "HETEROGENEOUS, true"
+ })
+ public void testMemberReplacementStickiness(SubscriptionType
subscriptionType, boolean rackAware) {
+ CommonAssignorTests.testMemberReplacementStickiness(assignor,
subscriptionType, rackAware);
}
Review Comment:
The `RangeAssignor` is not sticky when members are added or removed, so this
test fails.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
