xxxxxxjun commented on PR #22164:
URL: https://github.com/apache/kafka/pull/22164#issuecomment-5306654434
@jsancio one design question for you. `RaftClient.kraftVersion()` can return
the requested
version on the leader during an upgrade, so this metric can now move before
the upgrade
commits. I argued in the comment above that this is fine, since it matches
what
`KRaftMetadataCache.features()` already reports to clients. You wrote
#19205, so does that
reasoning hold from your side, or would you rather this wait for a
committed-only accessor
on RaftClient?
This PR's CI run is at "action required" with zero jobs started, so it needs
a committer to
approve the workflow run. Local results on the rebased branch (JDK 21; CI
uses 17 and 25):
- `:metadata:test --tests '*MetadataLoaderTest*'`: 20 tests, 0 failures,
including
`testKRaftVersionFinalizedLevelMetric`
- `:metadata:checkstyleMain`, `:metadata:checkstyleTest`,
`:core:checkstyleMain`: pass
- `:metadata:spotlessJavaCheck`, `:core:spotlessJavaCheck`: pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
