Parkerhiphop commented on code in PR #22907: URL: https://github.com/apache/kafka/pull/22907#discussion_r3792032256
########## core/src/test/scala/integration/kafka/api/SaslClientsWithInvalidCredentialsTest.scala: ########## @@ -1,238 +0,0 @@ -/** - * Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE - * file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file - * to You under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the - * License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on - * an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the - * specific language governing permissions and limitations under the License. - */ -package kafka.api - -import java.time.Duration -import java.util.Properties -import java.util.concurrent.{ExecutionException, TimeUnit} -import org.apache.kafka.clients.admin.{Admin, AdminClientConfig} -import org.apache.kafka.clients.consumer.{Consumer, ConsumerConfig} -import org.apache.kafka.clients.producer.{KafkaProducer, ProducerConfig, ProducerRecord} -import org.apache.kafka.common.{KafkaException, TopicPartition} -import org.apache.kafka.common.errors.SaslAuthenticationException -import org.junit.jupiter.api.{AfterEach, BeforeEach, Test, TestInfo} -import org.junit.jupiter.api.Assertions._ -import kafka.utils.{TestInfoUtils, TestUtils} -import org.apache.kafka.common.config.SaslConfigs -import org.apache.kafka.common.security.auth.SecurityProtocol -import org.apache.kafka.coordinator.group.GroupCoordinatorConfig -import org.apache.kafka.coordinator.transaction.TransactionLogConfig -import org.apache.kafka.metadata.storage.Formatter -import org.apache.kafka.security.JaasTestUtils -import org.junit.jupiter.params.ParameterizedTest -import org.junit.jupiter.params.provider.{MethodSource, ValueSource} - -import scala.jdk.javaapi.OptionConverters -import scala.util.Using - -class SaslClientsWithInvalidCredentialsTest extends AbstractSaslTest { - private val kafkaClientSaslMechanism = "SCRAM-SHA-256" - private val kafkaServerSaslMechanisms = List(kafkaClientSaslMechanism) - override protected val securityProtocol = SecurityProtocol.SASL_PLAINTEXT - override protected val serverSaslProperties = Some(kafkaServerSaslProperties(kafkaServerSaslMechanisms, kafkaClientSaslMechanism)) - override protected val clientSaslProperties = Some(kafkaClientSaslProperties(kafkaClientSaslMechanism)) - val consumerCount = 1 - val producerCount = 1 - val brokerCount = 1 - - this.serverConfig.setProperty(GroupCoordinatorConfig.OFFSETS_TOPIC_REPLICATION_FACTOR_CONFIG, "1") - this.serverConfig.setProperty(TransactionLogConfig.TRANSACTIONS_TOPIC_REPLICATION_FACTOR_CONFIG, "1") - this.serverConfig.setProperty(TransactionLogConfig.TRANSACTIONS_TOPIC_MIN_ISR_CONFIG, "1") - this.consumerConfig.setProperty(ConsumerConfig.AUTO_OFFSET_RESET_CONFIG, "earliest") Review Comment: Yes. Although ClusterInstance.consumer(...) currently defaults auto.offset.reset to earliest, it's still better to make it explicit here as well to preserve the migrated test's setup independent of ClusterInstance defaults. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
