chia7712 commented on code in PR #23190:
URL: https://github.com/apache/kafka/pull/23190#discussion_r3804331618
##########
share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorShard.java:
##########
@@ -563,15 +563,23 @@ public
CoordinatorResult<InitializeShareGroupStateResponseData, CoordinatorRecor
InitializeShareGroupStateRequestData.PartitionData partitionData =
topicData.partitions().get(0);
Review Comment:
Out of curiosity. Do we plan to make `initializeState` support multiple keys
in the future? If not, should `initializeState` accept `groupId`, `topicId`,
and `PartitionData` directly instead of `InitializeShareGroupStateRequestData`?
It brings the following benefits:
1. we don't need to construct construct single-element
`InitializeShareGroupStateRequestData` objects again in the service layer
2. we can avoid the hardcoded .get(0) calls in the shard layer
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
