AndrewJSchofield commented on code in PR #23224:
URL: https://github.com/apache/kafka/pull/23224#discussion_r3828271513
##########
share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorShard.java:
##########
@@ -545,23 +545,25 @@ public
CoordinatorResult<DeleteShareGroupStateResponseData, CoordinatorRecord> d
* the request data which covers only key i.e. group1:topic1:partition1.
The implementation
Review Comment:
nit: (and in similar comments) "covers only key" probably should be "covers
only one key". And now, with this change, the comment is explaining something
which no longer needs explaining.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
