Parkerhiphop commented on code in PR #23125:
URL: https://github.com/apache/kafka/pull/23125#discussion_r3838416793
##########
server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java:
##########
@@ -205,10 +207,10 @@ public void
testRegisterBrokerRecordVersion(MetadataVersion metadataVersion) {
}
@Test
- public void assertLatestProductionIsLessThanLatest() {
- assertTrue(LATEST_PRODUCTION.ordinal() <
MetadataVersion.latestTesting().ordinal(),
+ public void assertLatestProductionIsNotAfterLatestTesting() {
Review Comment:
I opened a follow-up PR for it: https://github.com/apache/kafka/pull/23244
##########
server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java:
##########
@@ -205,10 +207,10 @@ public void
testRegisterBrokerRecordVersion(MetadataVersion metadataVersion) {
}
@Test
- public void assertLatestProductionIsLessThanLatest() {
- assertTrue(LATEST_PRODUCTION.ordinal() <
MetadataVersion.latestTesting().ordinal(),
+ public void assertLatestProductionIsNotAfterLatestTesting() {
Review Comment:
Got it. I opened a follow-up PR for it:
https://github.com/apache/kafka/pull/23244
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
