Russole commented on code in PR #22824:
URL: https://github.com/apache/kafka/pull/22824#discussion_r3839187071
##########
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/TimeWindowedKStreamIntegrationTest.java:
##########
@@ -390,7 +392,9 @@ public void shouldRestoreAfterJoinRestart(final
StrategyType type, final boolean
assertThat(windowedMessages, is(expectResult));
- kafkaStreams.close();
+ // Leave the group on close so the immediate restart below does not
have to wait for the
+ // previous member to be evicted via session timeout (~45s) before its
rebalance completes.
+
kafkaStreams.close(CloseOptions.groupMembershipOperation(GroupMembershipOperation.LEAVE_GROUP));
Review Comment:
HeadersStoreUpgradeIntegrationTest has the same pattern:
https://github.com/apache/kafka/blob/trunk/streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/HeadersStoreUpgradeIntegrationTest.java
I'll fix it in a follow-up patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
