mingyen066 commented on code in PR #23248:
URL: https://github.com/apache/kafka/pull/23248#discussion_r3844852808
##########
tests/kafkatest/benchmarks/core/benchmark_test.py:
##########
@@ -398,4 +398,4 @@ def test_share_consumer_throughput(self,
compression_type="none", security_proto
return compute_aggregate_throughput(self.share_consumer)
def validate_versions(self, client_version, broker_version):
- assert client_version <= broker_version, "Client version %s should be
<= than broker version %s" (client_version, broker_version)
+ assert client_version <= broker_version, "Client version %s should be
<= than broker version %s" % (client_version, broker_version)
Review Comment:
nit: `"Client version %s should be <= broker version %s"` — `than` is
redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
