[
https://issues.apache.org/jira/browse/KAFKA-20975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18107511#comment-18107511
]
Mickael Maison commented on KAFKA-20975:
----------------------------------------
You need to wait for a maintainer to review the PR. Considering it's a very
minor change and there is a lot of work happening for the 4.4.0 release right
now, it may take a little while.
I see you manually added Reviewers (Reviewers: Ken Huang [email protected],
Chia-Ping Tsai [email protected]) to the PR body, you should not do that.
Reviewers are automatically added once they have done a review.
> Remove hamcrest from streams test-utils
> ---------------------------------------
>
> Key: KAFKA-20975
> URL: https://issues.apache.org/jira/browse/KAFKA-20975
> Project: Kafka
> Issue Type: Sub-task
> Reporter: Shantanu
> Assignee: Shantanu
> Priority: Major
>
> Subtask of KAFKA-20948 (migrate hamcrest tests to JUnit).Scope:
> streams/test-utils module tests that still use org.hamcrest. This package is
> not covered by the existing package-scoped subtasks.Files:*
> streams/test-utils/src/test/java/org/apache/kafka/streams/KeyValueStoreFacadeTest.java*
>
> streams/test-utils/src/test/java/org/apache/kafka/streams/WindowStoreFacadeTest.java*
>
> streams/test-utils/src/test/java/org/apache/kafka/streams/TestTopicsTest.java*
>
> streams/test-utils/src/test/java/org/apache/kafka/streams/TopologyTestDriverTest.java*
>
> streams/test-utils/src/test/java/org/apache/kafka/streams/test/TestRecordTest.java*
>
> streams/test-utils/src/test/java/org/apache/kafka/streams/test/MockProcessorContextAPITest.java*
>
> streams/test-utils/src/test/java/org/apache/kafka/streams/test/wordcount/WindowedWordCountProcessorTest.javaConvert
> hamcrest assertThat usage to JUnit 5 assertions line by line. No production
> code changes.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
