chia7712 commented on code in PR #22023:
URL: https://github.com/apache/kafka/pull/22023#discussion_r3847194168
##########
docker/test/fixtures/mode/isolated/docker-compose.yml:
##########
@@ -83,12 +83,14 @@ services:
- "9092:9092"
- "19093:9093"
- "9101:9101"
+ - "9095:9095"
volumes:
- ../../secrets:/etc/kafka/secrets
+ - ../../sasl:/etc/kafka/sasl
environment:
KAFKA_NODE_ID: 4
- KAFKA_LISTENER_SECURITY_PROTOCOL_MAP:
'CONTROLLER:PLAINTEXT,PLAINTEXT:PLAINTEXT,SSL:SSL,PLAINTEXT_HOST:PLAINTEXT'
- KAFKA_ADVERTISED_LISTENERS:
'PLAINTEXT_HOST://localhost:9092,SSL://localhost:19093,PLAINTEXT://broker1:29092'
+ KAFKA_LISTENER_SECURITY_PROTOCOL_MAP:
'CONTROLLER:PLAINTEXT,PLAINTEXT:PLAINTEXT,SSL:SSL,PLAINTEXT_HOST:PLAINTEXT,SASL_PLAINTEXT:SASL_PLAINTEXT'
Review Comment:
It seems we only set the SASL_PLAINTEXT listener for broker1, but the
partition created by the test could be hosted by broker2 or broker3, so the
client wouldn't be able to connect to the leader.
Am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
