MikeEdgar commented on code in PR #22865:
URL: https://github.com/apache/kafka/pull/22865#discussion_r3852691502
##########
clients/src/main/java/org/apache/kafka/common/security/ssl/DefaultSslEngineFactory.java:
##########
@@ -150,6 +154,13 @@ public void configure(Map<String, ?> configs) {
this.enabledProtocols = null;
}
+ List<String> namedGroupsList = (List<String>)
configs.get(SslConfigs.SSL_NAMED_GROUPS_CONFIG);
+ if (namedGroupsList != null && !namedGroupsList.isEmpty()) {
+ this.namedGroups = namedGroupsList.toArray(new String[0]);
+ } else {
+ this.namedGroups = null;
+ }
Review Comment:
I believe an empty array is a valid way to disable named groups for the
connection [1]. I.e., when they have been enabled using the JDK's
`jdk.tls.namedGroups` system property, but should not apply to the Kafka
connection.
[1]
https://github.com/openjdk/jdk25u/blob/50cd33365425c024f2959667cd8577a92af308e8/src/java.base/share/classes/sun/security/ssl/SSLConfiguration.java#L366-L373
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
