[ 
https://issues.apache.org/jira/browse/KAFKA-20987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18108160#comment-18108160
 ] 

Shantanu commented on KAFKA-20987:
----------------------------------

Opened GitHub PR: https://github.com/apache/kafka/pull/23278

> Remove hamcrest from org.apache.kafka.streams.processor.internals.metrics 
> package
> ---------------------------------------------------------------------------------
>
>                 Key: KAFKA-20987
>                 URL: https://issues.apache.org/jira/browse/KAFKA-20987
>             Project: Kafka
>          Issue Type: Sub-task
>          Components: streams
>            Reporter: Shantanu
>            Assignee: Shantanu
>            Priority: Major
>
> Subtask of [KAFKA-20948] (migrate hamcrest tests to JUnit).
> Scope: {{org.apache.kafka.streams.processor.internals.metrics}} tests that 
> still use {{org.hamcrest}}. This package is not covered by existing subtasks:
> - [KAFKA-20963] covers only {{org.apache.kafka.streams.processor}} (top-level)
> - [KAFKA-20965] covers {{org.apache.kafka.streams.state.internals.metrics}}
> Files:
> * 
> streams/src/test/java/org/apache/kafka/streams/processor/internals/metrics/ProcessorNodeMetricsTest.java
> * 
> streams/src/test/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImplTest.java
> * 
> streams/src/test/java/org/apache/kafka/streams/processor/internals/metrics/TaskMetricsTest.java
> * 
> streams/src/test/java/org/apache/kafka/streams/processor/internals/metrics/ThreadMetricsTest.java
> * 
> streams/src/test/java/org/apache/kafka/streams/processor/internals/metrics/TopicMetricsTest.java
> {{RebalanceListenerMetricsTest.java}} is in this package but does not use 
> hamcrest.
> Convert hamcrest {{assertThat}} usage to JUnit 5 assertions line by line. No 
> production code changes.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to