chia7712 commented on code in PR #22886:
URL: https://github.com/apache/kafka/pull/22886#discussion_r3862679004
##########
docker/docker_build_test.py:
##########
@@ -38,19 +38,26 @@
import argparse
import shutil
from test.docker_sanity_test import run_tests
-from common import execute, build_docker_image_runner
+from common import execute, build_docker_image_runner, detect_container_runtime
import tempfile
import os
-def run_docker_tests(image, tag, kafka_url, image_type):
+def run_docker_tests(image, tag, kafka_url, image_type,
container_runtime="docker"):
+ compose_command = f"{container_runtime}-compose"
Review Comment:
Relying on the legacy `docker-compose` / `podman-compose` commands is a bit
odd. We should detect which command is actually available and prefer the newer
one, e.g. try `xxx compose` first and fall back to `xxx-compose`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
