chia7712 commented on code in PR #23269:
URL: https://github.com/apache/kafka/pull/23269#discussion_r3863879527
##########
tests/kafkatest/tests/streams/streams_application_upgrade_test.py:
##########
@@ -68,12 +68,12 @@ def perform_broker_upgrade(self, to_version):
self.kafka.start_node(node)
@cluster(num_nodes=9)
- @matrix(from_version=smoke_test_versions, bounce_type=["full"],
metadata_quorum=[quorum.combined_kraft])
- def test_app_upgrade(self, from_version, bounce_type, metadata_quorum):
+ @matrix(from_version=smoke_test_versions,
metadata_quorum=[quorum.combined_kraft])
+ def test_app_upgrade(self, from_version, metadata_quorum):
"""
Starts 3 KafkaStreams instances with <old_version>, and upgrades
one-by-one to <new_version>
Review Comment:
Would you mind updating the docstring? The one-by-one is obsolete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
