m1a2st commented on code in PR #23287:
URL: https://github.com/apache/kafka/pull/23287#discussion_r3868033707
##########
streams/src/test/java/org/apache/kafka/test/MockApiFixedKeyProcessor.java:
##########
@@ -93,23 +92,23 @@ public void process(final FixedKeyRecord<KIn, VIn> record) {
}
public void checkAndClearProcessResult(final KeyValueTimestamp<?, ?>...
expected) {
- assertThat("the number of outputs:" + processed, processed.size(),
is(expected.length));
+ assertEquals(expected.length, processed.size(), () -> "the number of
outputs:" + processed);
Review Comment:
```suggestion
assertEquals(expected.length, processed.size(), "the number of
outputs:" + processed);
```
##########
streams/src/test/java/org/apache/kafka/test/MockApiFixedKeyProcessor.java:
##########
@@ -120,16 +119,16 @@ public void requestCommit() {
}
public void checkEmptyAndClearProcessResult() {
- assertThat("the number of outputs:", processed.size(), is(0));
+ assertEquals(0, processed.size(), "the number of outputs:");
Review Comment:
```suggestion
assertEquals(0, processed.size(), "the number of outputs:" +
processed);
```
##########
streams/src/test/java/org/apache/kafka/test/MockApiFixedKeyProcessor.java:
##########
@@ -120,16 +119,16 @@ public void requestCommit() {
}
public void checkEmptyAndClearProcessResult() {
- assertThat("the number of outputs:", processed.size(), is(0));
+ assertEquals(0, processed.size(), "the number of outputs:");
processed.clear();
}
public void checkAndClearPunctuateResult(final PunctuationType type, final
long... expected) {
final ArrayList<Long> punctuated = type == PunctuationType.STREAM_TIME
? punctuatedStreamTime : punctuatedSystemTime;
- assertThat("the number of outputs:", punctuated.size(),
is(expected.length));
+ assertEquals(expected.length, punctuated.size(), "the number of
outputs:");
Review Comment:
ditto
##########
streams/src/test/java/org/apache/kafka/test/MockApiFixedKeyProcessor.java:
##########
@@ -93,23 +92,23 @@ public void process(final FixedKeyRecord<KIn, VIn> record) {
}
public void checkAndClearProcessResult(final KeyValueTimestamp<?, ?>...
expected) {
- assertThat("the number of outputs:" + processed, processed.size(),
is(expected.length));
+ assertEquals(expected.length, processed.size(), () -> "the number of
outputs:" + processed);
for (int i = 0; i < expected.length; i++) {
final FixedKeyRecord<KIn, VIn> record = processed.get(i);
- assertThat(
- "output[" + i + "]:",
+ assertEquals(
+ expected[i],
new KeyValueTimestamp<>(record.key(), record.value(),
record.timestamp()),
- is(expected[i])
+ "output[" + i + "]:"
);
}
processed.clear();
}
public void checkAndClearProcessedRecords(final Record<?, ?>... expected) {
- assertThat("the number of outputs:" + processed, processed.size(),
is(expected.length));
+ assertEquals(expected.length, processed.size(), () -> "the number of
outputs:" + processed);
Review Comment:
```suggestion
assertEquals(expected.length, processed.size(), "the number of
outputs:" + processed);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
