shantanushukla commented on PR #23279:
URL: https://github.com/apache/kafka/pull/23279#issuecomment-5439610695
@m1a2st Thanks for the review. Converted `AssignmentTestUtils` to JUnit 5 as
well: the remaining `assertThat` calls are gone, and the custom Hamcrest
matchers (`hasActiveTasks` / `hasAssignedTasks` / `hasStandbyTasks` /
`hasProperty`) are replaced with direct assertions in `ClientStateTest`,
`TaskMovementTest`, and `HighAvailabilityTaskAssignorTest`.
`testFixturesImplementation libs.hamcrest` is now removed from `:streams`
since no test fixture uses Hamcrest anymore. `:streams` test code still keeps
`testImplementation libs.hamcrest` for the rest of the assignment tests.
```
./gradlew :streams:test \
--tests
org.apache.kafka.streams.processor.internals.assignment.ClientStateTest \
--tests
org.apache.kafka.streams.processor.internals.assignment.TaskMovementTest \
--tests
org.apache.kafka.streams.processor.internals.assignment.HighAvailabilityTaskAssignorTest
\
:streams:checkstyleTest :streams:spotlessCheck
```
BUILD SUCCESSFUL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
