mimaison commented on code in PR #23150:
URL: https://github.com/apache/kafka/pull/23150#discussion_r3880635478
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/rest/ConnectRestServerTest.java:
##########
@@ -327,6 +329,80 @@ public void testIndependentAdminEndpoint() throws
IOException {
assertEquals(404, response.getStatusLine().getStatusCode());
}
+ @Test
+ public void testRestExtensionsRegisteredWithAdminListener() throws
IOException {
+ Map<String, String> configMap = new HashMap<>(baseServerProps());
+ configMap.put(RestServerConfig.ADMIN_LISTENERS_CONFIG,
"http://localhost:0";);
+ configMap.put(RestServerConfig.REST_EXTENSION_CLASSES_CONFIG,
HeaderConnectRestExtension.class.getName());
+
+ HeaderConnectRestExtension extension = new
HeaderConnectRestExtension();
+ doReturn(KAFKA_CLUSTER_ID).when(herder).kafkaClusterId();
+ doReturn(plugins).when(herder).plugins();
+ doReturn(List.of(extension)).when(plugins).newPlugins(any(), any(),
eq(ConnectRestExtension.class));
+ doReturn(List.of()).when(herder).connectors();
+
+ server = new ConnectRestServer(null, restClient, configMap);
+ server.initializeServer();
+ server.initializeResources(herder);
+
+ assertNotEquals(server.advertisedUrl(), server.adminUrl());
+ assertEquals(2, extension.registrations);
+
+ HttpResponse regularResponse = executeRequest(server.advertisedUrl(),
new HttpGet("/connectors"));
+ assertEquals(200, regularResponse.getStatusLine().getStatusCode());
+ assertNotNull(regularResponse.getFirstHeader(extension.name));
+
+ HttpResponse adminResponse = executeRequest(server.adminUrl(), new
HttpGet("/admin/loggers"));
+ assertEquals(200, adminResponse.getStatusLine().getStatusCode());
+ assertNotNull(adminResponse.getFirstHeader(extension.name));
+ }
+
+ @Test
+ public void testRestExtensionsWithoutAdminListener() throws IOException {
+ Map<String, String> configMap = new HashMap<>(baseServerProps());
+ configMap.put(RestServerConfig.REST_EXTENSION_CLASSES_CONFIG,
HeaderConnectRestExtension.class.getName());
+
+ HeaderConnectRestExtension extension = new
HeaderConnectRestExtension();
+ doReturn(KAFKA_CLUSTER_ID).when(herder).kafkaClusterId();
+ doReturn(plugins).when(herder).plugins();
+ doReturn(List.of(extension)).when(plugins).newPlugins(any(), any(),
eq(ConnectRestExtension.class));
+ doReturn(List.of()).when(herder).connectors();
+
+ server = new ConnectRestServer(null, restClient, configMap);
+ server.initializeServer();
+ server.initializeResources(herder);
+
+ assertEquals(1, extension.registrations);
+
+ HttpResponse response = executeRequest(server.advertisedUrl(), new
HttpGet("/connectors"));
+ assertEquals(200, response.getStatusLine().getStatusCode());
+ assertNotNull(response.getFirstHeader(extension.name));
Review Comment:
Feel free to followup with a PR. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
