alanlau28 commented on PR #23285: URL: https://github.com/apache/kafka/pull/23285#issuecomment-5456589272
> Thanks @alanlau28 this LGTM now. There's one minor comment to address. > > I think we could expande the test coverage some - if you agree, we can do this in a follow-up PR. > > 1. multiple partitions — in a single restore call, register three windowed active partitions (large gap → skips past stored offset, empty/truncated > log → demotes to floor+pause, probe unresolved → falls back to floor) and assert each lands at its own position with no cross-partition leakage in the removeAll/floor-map bookkeeping. > 2. long retention time — a windowed active store whose retentionPeriod() returns Long.MAX_VALUE must skip the probe entirely (plain seek(storedOffset + 1), no offsetsForTimes call), guarding against the latestTimestamp - retention underflow. Sg! I'll make a follow up PR for this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
