chia7712 commented on code in PR #23250:
URL: https://github.com/apache/kafka/pull/23250#discussion_r3893095888
##########
clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/MetricsDuringTopicCreationDeletionTest.java:
##########
@@ -77,23 +78,30 @@ public void testMetricsDuringTopicCreateDelete() throws
Exception {
final int initialPreferredReplicaImbalanceCount =
getGauge("PreferredReplicaImbalanceCount").value();
final int initialUnderReplicatedPartitionsCount =
getGauge("UnderReplicatedPartitions").value();
+ AtomicInteger offlinePartitionsCount = new
AtomicInteger(initialOfflinePartitionsCount);
+ AtomicInteger preferredReplicaImbalanceCount = new
AtomicInteger(initialPreferredReplicaImbalanceCount);
+ AtomicInteger underReplicatedPartitionsCount = new
AtomicInteger(initialUnderReplicatedPartitionsCount);
+
CompletableFuture<Void> future = CompletableFuture.runAsync(() -> {
while (running) {
- int offlinePartitionsCount =
getGauge("OfflinePartitionsCount").value();
- int preferredReplicaImbalanceCount =
getGauge("PreferredReplicaImbalanceCount").value();
- int underReplicatedPartitionsCount =
getGauge("UnderReplicatedPartitions").value();
-
- if (offlinePartitionsCount != initialOfflinePartitionsCount ||
- preferredReplicaImbalanceCount !=
initialPreferredReplicaImbalanceCount ||
- underReplicatedPartitionsCount !=
initialUnderReplicatedPartitionsCount) {
+
offlinePartitionsCount.set(getGauge("OfflinePartitionsCount").value());
+ preferredReplicaImbalanceCount.set(
+ getGauge("PreferredReplicaImbalanceCount").value());
+ underReplicatedPartitionsCount.set(
+ getGauge("UnderReplicatedPartitions").value());
+
+ if (offlinePartitionsCount.get() !=
initialOfflinePartitionsCount ||
+ preferredReplicaImbalanceCount.get() !=
initialPreferredReplicaImbalanceCount ||
+ underReplicatedPartitionsCount.get() !=
initialUnderReplicatedPartitionsCount) {
Review Comment:
I just realized that there is only one broker, so those gauges can never
exceed zero .... Would you mind fixing that in this PR as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
