chia7712 commented on code in PR #23291:
URL: https://github.com/apache/kafka/pull/23291#discussion_r3897354318
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/AssignorConfigurationTest.java:
##########
@@ -46,12 +44,11 @@ public void setup() {
@Test
public void configsShouldRejectZeroWarmups() {
- final ConfigException exception = assertThrows(
+ assertThrows(
ConfigException.class,
- () -> new AssignmentConfigs(1L, 0, 1, 1L,
EMPTY_RACK_AWARE_ASSIGNMENT_TAGS)
+ () -> new AssignmentConfigs(1L, 0, 1, 1L,
EMPTY_RACK_AWARE_ASSIGNMENT_TAGS),
+ "Invalid value 0 for configuration max.warmup.replicas"
Review Comment:
ditto - we should verify the error message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
