shoemoney commented on PR #23274:
URL: https://github.com/apache/kafka/pull/23274#issuecomment-5500682811
Honest answer: no, not deterministically. I wrote a stress harness (12
inputs spanning 1 B to ~7 TB so the shared `DigitList` sees very different
digit counts, 64 threads × 400k calls each, results compared against
single-threaded output) and on OpenJDK 21.0.10 it produced zero mismatches. The
PR body's "corrupts output" was overstated — the basis for the change is the
`DecimalFormat` Javadoc ("not synchronized … create separate format instances
for each thread"), not an observed failure in Kafka. I've rewritten the
description to say exactly that. If a `ThreadLocal` for a contract-only race
isn't worth carrying, I'm fine closing this; if you'd rather keep the
hardening, it's rebased and green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
