see-quick commented on code in PR #23328:
URL: https://github.com/apache/kafka/pull/23328#discussion_r3912283774
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java:
##########
Review Comment:
I know it's not part of the PR but when doing analysis of this code ... I
think it deserves a bit better description here i.e.,
```suggestion
// Build a reverse index for constant-time lookup of each
partition's current owner
```
and I think instead calling it allPartitions I would call it
`partitionOwners` as it contains only assigned partitions and maps each
partition to its owner, so I think current name is a bit vauge?
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java:
##########
Review Comment:
```suggestion
// For each consumer that can accept more partitions, check whether moving
an eligible
// partition from a consumer with at least two more assignments would
improve balance.
```
also this seems a bit confusing when I am reading it but it could be just me
...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
