majialoong commented on code in PR #23334:
URL: https://github.com/apache/kafka/pull/23334#discussion_r3916412818
##########
tests/kafkatest/services/performance/end_to_end_latency.py:
##########
@@ -44,12 +44,13 @@ class EndToEndLatencyService(PerformanceService):
"collect_default": True}
}
- def __init__(self, context, num_nodes, kafka, topic, num_records,
compression_type="none", version=DEV_BRANCH, acks=1):
+ def __init__(self, context, num_nodes, kafka, topic, num_records,
compression_type="none", version=DEV_BRANCH, acks=1, settings=None):
Review Comment:
Good suggestion. `compression.type` is now passed through `settings`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
