mjsax commented on PR #23262:
URL: https://github.com/apache/kafka/pull/23262#issuecomment-5518637642
An unknown status code leads to an `IllegalArgumentException` in
`StreamsGroupHeartbeatResponse.java` (generated code):
```
public static Status fromCode(byte code) {
Status status = CODE_TO_STATUS.get(code);
if (status == null) {
throw new IllegalArgumentException("Unknown code " + code);
}
return status;
}
```
And this `IllegalArgumentException` is getting swallowed (cf
https://issues.apache.org/jira/browse/KAFKA-20860) as pointed on on the ticket
description, putting the client into a zombie state.
When we added the new status-code, we added a broker side guard to not set
the new code for older clients (ie, v0 response). -- I was not aware that
"unknown status code" would be valid, and the client could just ignore it. For
this case, we could simplify the broker code and just keep sending it; of
course, we still need a PR client side (we could repurpose this PR for it), to
ensure we don't crash and just ignore the unknown code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
